Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

match doc string with its config_param #1633

Merged
merged 1 commit into from
Jul 28, 2017
Merged

match doc string with its config_param #1633

merged 1 commit into from
Jul 28, 2017

Conversation

mindw
Copy link
Contributor

@mindw mindw commented Jul 14, 2017

No description provided.

@repeatedly
Copy link
Member

repeatedly commented Jul 20, 2017 •
edited
Loading

It seems resolve_hostname's desc is incorrect.
Could you update the desc with

fluentd/lib/fluent/plugin/in_forward.rb

Line 46 in c8c4ff7

desc 'Try to resolve hostname from IP addresses or not.'
?

@repeatedly repeatedly self-assigned this Jul 20, 2017
@repeatedly repeatedly added the bug Something isn't working label Jul 20, 2017
@mindw
Copy link
Contributor Author

mindw commented Jul 22, 2017

updated, squashed and rebased.

@repeatedly repeatedly merged commit f9b26b1 into fluent:master Jul 28, 2017
@repeatedly
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@repeatedly repeatedly

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mindw @repeatedly