Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ack handling #1581

Merged
merged 3 commits into from
May 26, 2017
Merged

Fix ack handling #1581

merged 3 commits into from
May 26, 2017

Conversation

repeatedly
Copy link
Member

No description provided.

@repeatedly repeatedly mentioned this pull request May 24, 2017
Closed
@repeatedly repeatedly self-assigned this May 25, 2017
@repeatedly repeatedly added bug Something isn't working v0.14 labels May 25, 2017
@repeatedly
Copy link
Member Author

@mururu Could you check this patch?

@mururu
Copy link
Member

mururu commented May 25, 2017

#1484 is about failure of heartbeat, but ecbdf8d is a fix for socket leak. So the commit message seems wrong. Except for that, LGTM.

@repeatedly
Copy link
Member Author

Yeah, because tcp heartbeat is hung by socket leak. commit message shows it.

@mururu
Copy link
Member

mururu commented May 26, 2017

because tcp heartbeat is hung by socket leak

I see. It looks perfect.

@repeatedly repeatedly requested a review from mururu May 26, 2017 08:52
@repeatedly repeatedly merged commit 03e2c3a into master May 26, 2017
@ganmacs ganmacs deleted the fix-ack-handling branch July 11, 2019 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mururu mururu mururu approved these changes

Assignees

@repeatedly repeatedly

Labels
bug Something isn't working v0.14
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@repeatedly @mururu