Handle wildcards in windows files paths in the in_tail plugin. #1541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently tail plugins on windows will work if a specific file is targeted: <source> type tail format none path C:\SomeDir\Logs\the.logs tag custom-logs </source> However with wildcards the log files will not be picked up: <source> type tail format none path C:\SomeDir\Logs\**\*' tag custom-logs </source> This is due to Dir.glob not handing '\'. The '\' must be converted to '/'. FIle.* methods will take either a '\' or '/' so just changing all '\' from the start is the easist. Users could define paths with '/'s but this is not idomatic for windows users.
|
Your approach is incomplete. |
|
Ops I missed that issue, sorry! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently tail plugins on windows will work if a specific file is targeted:
However with wildcards the log files will not be picked up:
This is due to Dir.glob not handing ''s properly. The '' must be converted to '/'. FIle.* methods will take either a '' or '/'.
Users could define paths with '/'s but this is not idiomatic for windows users.