in_monitor_agent: enable to select instance variables of plugins #1393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
repeatedly
reviewed
Jan 3, 2017
|
|
||
| data(:with_config_and_retry_yes => [true, true, false, "?with_config=yes&with_retry"], | ||
| :with_config_and_retry_no => [false, false, false, "?with_config=no&with_retry=no"], | ||
| :with_ivars_given => [false, false, true, "?with_config=no&with_retry=no&with_ivars=id,num_errors"]) |
repeatedly
reviewed
Jan 3, 2017
| elsif ivars = opts[:ivars] | ||
| iv = {} | ||
| ivars.each {|name| | ||
| iname = :"@#{name}" |
There was a problem hiding this comment.
@repeatedly I chose symbol literal instead of string because reduce garbage. Is this too careful?
There was a problem hiding this comment.
What does 'garbage' mean?
:"@#{name}" is dynamic symbol genaration via string, not static literal.
There was a problem hiding this comment.
@repeatedly Sorry, I had misunderstood. I will update patch, so please wait.
|
@repeatedly Thanks for review and merge! But, I need this feature for v0.12.x also. |
|
@autopp Yeah. This is good > for v0.12 |
|
@repeatedly OK, please wait... |
Merged
|
I created pull request #1402 to port this feature. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I often use
in_monitor_agentwith/api/plugins.json&debug=1for more complexity plugin monitoring and inspecting.In this case, only some instance variables of a specific plugin is needed.
Unfortunary,
&debug=1makes responce size too large. (Also, pretty printing is not needed...)To reduce size of response, this PR add query parameter
with_ivarsfor/api/plugins.json.with_ivarsshould be a names sepalated by comma.When
with_ivarsis given, the response hasinstance_variablesthat contains only specified instance variables for each plugin(This is the same as '&debug=1').E.g.
If
with_ivarsis not good name, please give me other idea. (E.g.with_instance_variables)