optimize to split lines #1325
Merged
optimize to split lines #1325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@repeatedly Could you review this change? |
repeatedly
reviewed
Nov 25, 2016
| @@ -570,8 +570,8 @@ def on_notify | |||
| else | |||
| @buffer << @io.readpartial(2048, @iobuf) | |||
| end | |||
| while line = @buffer.slice!(/.*?\n/m) | |||
| @lines << line | |||
| while idx = @buffer.index("\n") | |||
There was a problem hiding this comment.
For more small optimization, "\n".freeze is better,
tagomoris
force-pushed
the
optimize-split-lines-in_tail
branch
from
06d2d41
to
93d507f
Compare
|
I pushed an updated commit. |
|
Looks good to me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1324.