Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a bug not to overwrite default value with nil #1296

Merged
merged 2 commits into from
Oct 27, 2016
Merged

Fix a bug not to overwrite default value with nil #1296

merged 2 commits into from
Oct 27, 2016

Conversation

tagomoris
Copy link
Member

No description provided.

@tagomoris
Copy link
Member Author

@repeatedly could you check this?

@tagomoris tagomoris mentioned this pull request Oct 26, 2016
Merged
@repeatedly
Copy link
Member

Test failed.
Is this change the cause?

@tagomoris
Copy link
Member Author

Originally, it's a wrong manner code... I added a commit to fix that.

@tagomoris
Copy link
Member Author

Can I merge this?

@repeatedly
Copy link
Member

LGTM

@tagomoris tagomoris merged commit 566038a into master Oct 27, 2016
@tagomoris tagomoris deleted the fix-bug-not-to-overwrite-default-value-with-nil branch October 27, 2016 03:57
@tagomoris tagomoris mentioned this pull request Nov 8, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@repeatedly repeatedly

Labels
v0.14
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tagomoris @repeatedly