Run TailWatcher#on_notify before attaching triggers#1261
Merged
repeatedly merged 1 commit intofluent:masterfrom Oct 5, 2016
Merged
Run TailWatcher#on_notify before attaching triggers#1261repeatedly merged 1 commit intofluent:masterfrom
repeatedly merged 1 commit intofluent:masterfrom
Conversation
This commit runs `TailWatcher#on_notify` before attaching `stat_trigger` and `timer_trigger` and prevents `TailWatcher#on_notify` from running in two different threads(main and event loop thread) at the same time. This change fixes the `can't modify string; temporarily locked` error. I think fluentd v0.12 does not raise the `can't modify string; temporarily locked` error because it runs `stat_trigger` and `timer_trigger` after `TailInput#start` finishes and thus `TailWatcher#on_notify` is not executed in two threads simultaneously. fluentd v0.12 in_tail.rb ```ruby def start @loop = Coolio::Loop.new refresh_watchers @thread = Thread.new(&method(:run)) end def run @loop.run end ```
Member
|
Thanks 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related to #1229
This commit runs
TailWatcher#on_notifybefore attachingstat_triggerandtimer_triggerand preventsTailWatcher#on_notifyfrom running in two different threads(main and event loop thread) at the same time.This change fixes the
can't modify string; temporarily lockederror.I think fluentd v0.12 does not raise the
can't modify string; temporarily lockederror because it runsstat_triggerandtimer_triggerafterTailInput#startfinishes and thusTailWatcher#on_notifyis not executed in two threads simultaneously.reproduction steps
same as described in #1229