Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge buffered and non buffered outputs #1200

Merged
merged 6 commits into from
Sep 2, 2016

Conversation

tagomoris
Copy link
Member

There are two buffer plugins to output events into null and stdout.
But Fluentd v0.14 API allows plugins to provide both in a plugin implementation.

This change is to merge these plugins into an implementation.

@tagomoris tagomoris added the v0.14 label Sep 1, 2016
@repeatedly
Copy link
Member

example/out_buffered_null.conf should be renamed to example/out_null.conf?

Fluent::Plugin.register_output('null', self)
Fluent::Plugin.register_output('buffered_null', self)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why buffered_null is needed?
This is introduced since v0.14 and there is no production use.
So we don't need to keep the compatibility.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay.

@tagomoris
Copy link
Member Author

Update for file/plugin names

@tagomoris tagomoris merged commit 2d4f730 into master Sep 2, 2016
@tagomoris tagomoris deleted the merge-buffered-and-non-buffered-outputs branch September 2, 2016 04:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants