fixup! Add StaticConfigAnalysis

Signed-off-by: Yuta Iwama <ganmacs@gmail.com>
fluent · Dec 18, 2019 · 4ea8f1c · 4ea8f1c
1 parent ce616a0
commit 4ea8f1c
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 0 deletions.
diff --git a/lib/fluent/static_config_analysis.rb b/lib/fluent/static_config_analysis.rb
@@ -128,6 +128,10 @@ def static_label_analyse(conf)
       ret = []
       conf.elements(name: 'label').each do |e|
         name = e.arg
+        if name.empty?
+          raise ConfigError, 'Missing symbol argument on <label> directive'
+        end
+
         if @labels[name]
           raise ConfigError, "Section <label #{name}> appears twice"
         end

diff --git a/test/test_static_config_analysis.rb b/test/test_static_config_analysis.rb
@@ -117,6 +117,19 @@ class StaticConfigAnalysisTest < ::Test::Unit::TestCase
         end
       end
 
+      test 'empty label' do
+        conf_data = <<-CONF
+<label>
+</label>
+CONF
+
+        c = Fluent::Config.parse(conf_data, '(test)', '(test_dir)', true)
+        assert_raise(Fluent::ConfigError.new('Missing symbol argument on <label> directive')) do
+          Fluent::StaticConfigAnalysis.call(c, workers: 2)
+        end
+      end
+
+
       data(
         'in filter' => 'filter',
         'in source' => 'source',