Runtime settings support #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can test it on : quay.io/jrottenberg/fluent2es:runtime-aws-es-user-passwd |
jrottenberg
force-pushed
the
runtime-aws-es-user-passwd
branch
from
903b43f to
e36d1d6
Compare
If FLUENT_ELASTICSEARCH_USER or FLUENT_ELASTICSEARCH_PASSWORD is not set, remove the corresponding lines from the config
jrottenberg
force-pushed
the
runtime-aws-es-user-passwd
branch
from
e36d1d6 to
bb0e17d
Compare
|
+1 Can someone here merge this in? |
|
+1 @jrottenberg thanks for the patch. Exactly what I needed. |
|
@edsiper Can we merge this or do you have any concern? |
|
@edsiper / @repeatedly - What else might need to be done before merging this in? |
|
@edsiper how about adding more maintainers to this repository? |
|
Any update on this? |
|
Will this pull request be accepted anytime soon? |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding entyrpoint so we can have runtime settings modifying the configuration.
Ideally that should address the concern pointed out on #41