Add moreoptions for elasticsearch config #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added two configs for elasticsearch: * reload_connections: Adding this as possible env variable will allow people that use AWS ES to disable the feature. I know there is a separate plugin for aws, but I'd like to stick with the original ES plugin. Adding this is a quick win for most people and doesn't interfere with how it works today * logstash_prefix: Another quick win allowing to customize the indexes used by fluent for ES
|
thanks |
|
@edsiper This PR didn't regenerate the templates before merging, so these changes didn't actually make it into the image. |
|
@zopanix that's part of it, but also my original statement is also true: this PR didn't regenerate the dockerfiles and configs, so this change wouldn't have resulted in updated images, even if builds were working. |
|
Shortly |
|
@chancez: cool thx |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey,
I'm proposing a pull request that just allows people to have a more customized setup with you docker image.
If you need me to create an issue for this please tell me.
Info:
Added two configs for elasticsearch: