Skip to content

linux-capability: add note for using CAP_DAC_READ_SEARCH in docker container #523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 23, 2024
Merged

linux-capability: add note for using CAP_DAC_READ_SEARCH in docker container #523

merged 1 commit into from
Dec 23, 2024

Conversation

Watson1978
Copy link
Contributor

@Watson1978 Watson1978 commented Dec 23, 2024 •
edited
Loading

Related to fluent/fluentd#4213

@Watson1978 Watson1978 requested review from kenhys and daipom December 23, 2024 08:58
daipom
daipom reviewed Dec 23, 2024
View reviewed changes
Copy link
Contributor

@daipom daipom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for this enhancement!
It looks basically good to me, but how about moving this section as follows?

I feel a separate section would be easier to understand because this is not directly related to in_tail.

Screenshot from 2024-12-23 18-08-58

kenhys
kenhys requested changes Dec 23, 2024
View reviewed changes
@Watson1978
linux-capability: add note for using CAP_DAC_READ_SEARCH in docker co…
24ac2d4 
…ntainer

Signed-off-by: Shizuo Fujita <fujita@clear-code.com>
@Watson1978 Watson1978 force-pushed the add-note-for-linux-capability branch from 240c1ef to 24ac2d4 Compare December 23, 2024 09:29
@Watson1978
Copy link
Contributor Author

Thanks.
I moved this to last section and add some explain.

@Watson1978 Watson1978 requested review from kenhys and daipom December 23, 2024 09:31
kenhys
kenhys approved these changes Dec 23, 2024
View reviewed changes
Copy link
Contributor

@kenhys kenhys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

daipom
daipom approved these changes Dec 23, 2024
View reviewed changes
Copy link
Contributor

@daipom daipom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@daipom daipom merged commit c6ff74c into fluent:1.0 Dec 23, 2024
1 check passed
@Watson1978 Watson1978 deleted the add-note-for-linux-capability branch December 23, 2024 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kenhys kenhys kenhys approved these changes

@daipom daipom daipom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Watson1978 @kenhys @daipom