Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix link to opensearch-ruby #85

Merged
merged 1 commit into from
Nov 25, 2022
Merged

Conversation

juergen-walter
Copy link
Contributor

@juergen-walter juergen-walter commented Nov 22, 2022

It just fixes a broken pointer in the documentation

(check all that apply)

  • tests added
  • tests passing
  • README updated (if needed)
  • README Table of Contents updated (if needed)
  • History.md and version in gemspec are untouched
  • backward compatible

Copy link
Collaborator

@cosmo0920 cosmo0920 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable but fluent org repos request to use Signed-off in the commits.
Could you add this signature with git commit -s --amend and git push origin patch-1?

https://github.com/opensearch/opensearch-ruby

Signed-off-by: Jürgen Walter <juergen.walter@sap.com>
@juergen-walter
Copy link
Contributor Author

Sorry, I did not align to the guidelines in the first place. Could have assumed it, did not check due to minor issue and time pressure for other topics. Just provided the fix via the github web ui quickly.

Thanks for sharing even the commands. Must be git push origin patch-1 -f ;-)

@cosmo0920 cosmo0920 merged commit de9cc6a into fluent:main Nov 25, 2022
@juergen-walter juergen-walter deleted the patch-1 branch November 25, 2022 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants