Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass a value of refresh_credentials_interval as duration_seconds #78

Merged
merged 1 commit into from
Jun 21, 2023
Merged

Pass a value of refresh_credentials_interval as duration_seconds #78

merged 1 commit into from
Jun 21, 2023

Conversation

cosmo0920
Copy link
Collaborator

@cosmo0920 cosmo0920 commented Sep 1, 2022 •
edited
Loading

Signed-off-by: Hiroshi Hatake hatake@calyptia.com

DESCRIPTION HERE

(check all that apply)

  • tests added
  • tests passing
  • README updated (if needed)
  • README Table of Contents updated (if needed)
  • History.md and version in gemspec are untouched
  • backward compatible

@cosmo0920 cosmo0920 mentioned this pull request Sep 1, 2022
Open
@cosmo0920 cosmo0920 force-pushed the pass-credentials-duration branch 2 times, most recently from a8c825c to 791ae0c Compare September 1, 2022 08:33
@salavessa salavessa mentioned this pull request Nov 7, 2022
Closed
@cosmo0920
Pass a value of refresh_credentials_interval as duration_seconds
b4a3cff 
Signed-off-by: Hiroshi Hatake <hatake@calyptia.com>
@cosmo0920 cosmo0920 force-pushed the pass-credentials-duration branch from 791ae0c to b4a3cff Compare June 19, 2023 09:11
@cosmo0920 cosmo0920 merged commit 17e2c49 into main Jun 21, 2023
@cosmo0920 cosmo0920 deleted the pass-credentials-duration branch June 21, 2023 02:38
cosmo0920 added a commit that referenced this pull request Jul 2, 2023
@cosmo0920
Revert "Merge pull request #78 from fluent/pass-credentials-duration"
f317af6 
This reverts commit 17e2c49, reversing
changes made to 66012d9.

This is because duration second should not be set up by default value.
Duration second should be user/account dependent.
cosmo0920 added a commit that referenced this pull request Jul 2, 2023
@cosmo0920
Merge pull request #108 from fluent/revert-duration
99511c6 
Revert "Merge pull request #78 from fluent/pass-credentials-duration"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@cosmo0920