Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deb rpm: add helper script to repack debug packages #692

Merged
merged 1 commit into from
Oct 23, 2024
Merged

deb rpm: add helper script to repack debug packages #692

merged 1 commit into from
Oct 23, 2024

Conversation

kenhys
Copy link
Contributor

@kenhys kenhys commented Oct 22, 2024

It is useful to investigate maintainer scripts.

@daipom
Copy link
Contributor

daipom commented Oct 22, 2024

Thanks! I see!
This script adds debug messages to the existing package!

@daipom
Copy link
Contributor

daipom commented Oct 22, 2024

Should the script name be test-repack-package?
To me, it looks like a test script, not a helper script.
Wouldn't a name like repack-package-with-debug-message, for example, be easier to understand?
(This might be long, though...)

@kenhys
deb rpm: add helper script converting to debug packages
21b5eb2 
It is useful to investigate maintainer scripts.

Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com>
daipom
daipom approved these changes Oct 23, 2024
View reviewed changes
Copy link
Contributor

@daipom daipom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@daipom daipom merged commit 955d1ef into fluent:feature-nodowntime Oct 23, 2024
59 of 63 checks passed
@kenhys kenhys deleted the repack-debug branch October 23, 2024 02:13
daipom pushed a commit to daipom/fluent-package-builder that referenced this pull request Oct 23, 2024
@kenhys @daipom
deb rpm: add helper script to repack debug packages (fluent#692)
50ee0d5 
It is useful to investigate maintainer scripts.

Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daipom daipom daipom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kenhys @daipom