Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deb: set correct contact #577

Merged
merged 1 commit into from
Aug 29, 2023
Merged

deb: set correct contact #577

merged 1 commit into from
Aug 29, 2023

Conversation

kenhys
Copy link
Contributor

@kenhys kenhys commented Aug 29, 2023

@kenhys
Copy link
Contributor Author

kenhys commented Aug 29, 2023

Follow up of #576

Upstream accepts URIs.

See https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/#upstream-contact-field

Signed-off-by: Kentaro Hayashi <kenhys@gmail.com>
Copy link
Contributor

@daipom daipom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
This fix looks good to me, but I noticed Fluentd developers <fluentd@googlegroups.com> is used too for Mainainer in the control files.
However, I can't find a document that says we can use a URL for it.

https://wiki.debian.org/Packaging/Intro#Step_3:_Add_the_Debian_packaging_files

Maintainer
The name and e-mail address of the person responsible for the package.

Should we keep Fluentd developers <fluentd@googlegroups.com> for Maintainer as it is because we have no choice?

Maintainer: Fluentd developers <fluentd@googlegroups.com>

Maintainer: Fluentd developers <fluentd@googlegroups.com>

Maintainer: Fluentd developers <fluentd@googlegroups.com>

@kenhys
Copy link
Contributor Author

kenhys commented Aug 29, 2023

Currently, URI is not accepted.

https://www.debian.org/doc/debian-policy/ch-controlfields.html#maintainer

@daipom daipom merged commit 01bd726 into fluent:master Aug 29, 2023
18 of 19 checks passed
@kenhys kenhys deleted the upstream-contact branch August 29, 2023 08:44
@kenhys kenhys added this to the 5.0.2 (T.B.D) milestone Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants