Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHANGELOG: fluent-plugin-windows-eventlog is not updated for v5.0.0 #569

Merged
merged 1 commit into from
Aug 15, 2023

Conversation

daipom
Copy link
Contributor

@daipom daipom commented Aug 15, 2023

No description provided.

Signed-off-by: Daijiro Fukuda <fukuda@clear-code.com>
@daipom
Copy link
Contributor Author

daipom commented Aug 15, 2023

This diff shows confusing results.
It may be because the path was changed.
We need to be careful with this 😢

v4.5.0...v5.0.0#diff-505194dbf36462a7c6dd7ff691a995d2ef382ed826c4b33877def49051df1550R88

Copy link
Contributor

@kenhys kenhys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Surely PR#522 doesn't update it.

I've overlooked it.

Thanks.

@kenhys kenhys merged commit 5666dfd into fluent:master Aug 15, 2023
11 checks passed
@daipom daipom deleted the changelog-5.0.0-fix-windows-eventlog branch August 15, 2023 07:58
@daipom
Copy link
Contributor Author

daipom commented Aug 15, 2023

Thanks for your review!

@kenhys kenhys mentioned this pull request Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants