helm-chart: Improve templates #1555
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Prevent template injection by using `quote` - Using `nindent` instead of `indent` to allow indenting templates for readability - Using `with` to reduce duplication Signed-off-by: Marco Franssen <marco.franssen@gmail.com>
joshuabaird
approved these changes
Apr 10, 2025
There was a problem hiding this comment.
Hi,
first of all, thank for your work.
With the template changes the following question comes up:
How I am supposed to reference a secretKey with the new template changes by quoting it?
E.g.:
httpPassword:
valueFrom:
secretKeyRef:
key: http_password
name: esauthbecomes
httpPassword: "map[valueFrom:map[secretKeyRef:map[key:http_password name:esauth]]]"Im no expert in Helm, do I miss something out?
Best Regards,
Rafael
joshuabaird
pushed a commit
to joshuabaird/fluent-operator
that referenced
this pull request
Oct 23, 2025
- Prevent template injection by using `quote` - Using `nindent` instead of `indent` to allow indenting templates for readability - Using `with` to reduce duplication Signed-off-by: Marco Franssen <marco.franssen@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
quotenindentinstead ofindentto allow indenting templates for readabilitywithto reduce duplication