-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
plugins: in_winevtlog: adds ability to ignore channels missing in Windows Event Log #6176
Conversation
Follows an example of the configuration file for the plugin.
|
Follows an example of operation when a channel (BogusChannel) is present in the list of channels to register to. The plugin correctly throws an error indicating it could not subscribe to channel BogusChannel but continues with the other channels it was able to subscribe to.
|
please sign off your commits (DCO error), you can do with at commit time with |
07197c3
to
a1d8fb5
Compare
Could you rebase off the current master? Some of commits seem to be contaminated. |
Will dig into that, Github and shared repositories are new to me. |
channels are missing on Windows Event Log ex: PowerShellCore/Operational needs the proper software installed to appear under Application and Services Log Signed-off-by: Meissner Morales <mmblanco@outlook.com>
Signed-off-by: Meissner Morales <mmblanco@outlook.com>
Signed-off-by: Meissner Morales <mmblanco@outlook.com>
a3006f2
to
6dfecdb
Compare
Signed-off-by: Meissner Morales <mmblanco@outlook.com>
Debug level message was added:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I'd confirmed that subscribing on non-existent channels does not cause fluent-bit termination. 👍
thanks |
Thanks! |
…t Log (fluent#6176) * Additions to in_winevtlog plugin to allow scenarios where one or more channels are missing on Windows Event Log, e.g: PowerShellCore/Operational needs the proper software installed to appear under Application and Services Log Signed-off-by: Meissner Morales <mmblanco@outlook.com> Signed-off-by: Manal Geries <mgeriesa@gmail.com>
…t Log (fluent#6176) * Additions to in_winevtlog plugin to allow scenarios where one or more channels are missing on Windows Event Log, e.g: PowerShellCore/Operational needs the proper software installed to appear under Application and Services Log Signed-off-by: Meissner Morales <mmblanco@outlook.com> Signed-off-by: root <root@sumit-acs.novalocal>
Additions to in_winevtlog plugin to allow scenarios where one or more channels are missing on Windows Event Log
ex: PowerShellCore/Operational needs the proper software installed to
appear under Application and Services Log
Enter
[N/A]
in the box, if an item is not applicable to your change.Testing
Before we can approve your change; please submit the following in a comment:
If this is a change to packaging of containers or native binaries then please confirm it works for all targets.
Documentation
Added information in comments
Backporting
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.