ci: use AppVeyor to generate Windows installers - #1224
Merged
Conversation
added 3 commits
March 26, 2019 14:10
Previously we appended the build machine's CPU architecture to each
package name in order to identify bitness (x86/x64).
td-agent-bit-1.1.0-1.AMD64.exe
However, on MSVC, we can target 32/64-bit by switching the compiler
option (like /p:PlatformTarget=x86), whose specification is more
significant for users.
With this patch, our Windows installers have file names that reflect
the platform option as below:
td-agent-bit-1.1.0-win32.exe ... x86 target build
td-agent-bit-1.1.0-win64.exe ... x64 target build
Signed-off-by: Fujimoto Seiji <fujimoto@clear-code.com>
This is a preparation for introducing Windows installer generation. The previous version tries to be smart by constructing the build option dynamically which results in messy option handling code. This patch expands the option handling code, removes bogus flags from there, and adds a missing flag that was actually required. Signed-off-by: Fujimoto Seiji <fujimoto@clear-code.com>
With this patch, AppVeyor automatically generates Windows installers
on each CI build. Something like below:
td-agent-bit-1.1.0-win32.exe
td-agent-bit-1.1.0-win64.exe
These installers are downloadable from the "Artifacts" tab in the
build detail page, and retained for 6 months.
Signed-off-by: Fujimoto Seiji <fujimoto@clear-code.com>
Member
|
great! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a set of patches that enables Windows installer generation
on AppVeyor.
bc9684b ci: tell AppVeyor to generate Windows installers
1b25b46 ci: clean up and simplify AppVeyor's build script
791a894 build: use CPack's default package name on Windows
With these patches applied, I can confirm that AppVeyor automatically
generates Windows installers on each CI build like below:
Part of #960