-
Notifications
You must be signed in to change notification settings - Fork 496
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
administration: add troubleshooting including tap functionality #929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m source Signed-off-by: elenacbc <elena@calyptia.com>
Signed-off-by: elenacbc <elena@calyptia.com>
Signed-off-by: elenacbc <elena@calyptia.com>
Signed-off-by: elenacbc <elena@calyptia.com>
Signed-off-by: elenacbc <elena@calyptia.com>
Signed-off-by: elenacbc <elena@calyptia.com>
Signed-off-by: elenacbc <elena@calyptia.com>
…ernals-signal Signed-off-by: elenacbc <elena@calyptia.com>
Signed-off-by: elenacbc <elena@calyptia.com>
…-signal Signed-off-by: elenacbc <elena@calyptia.com>
Signed-off-by: elenacbc <elena@calyptia.com>
…and added fluent-bit image Signed-off-by: elenacbc <elena@calyptia.com>
Signed-off-by: elenacbc <elena@calyptia.com>
elenacbc
changed the title
Tap doc
administration: add troubleshooting including tap functionality
Oct 20, 2022
patrick-stephens
requested changes
Oct 20, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good but a few things I think need covering:
- I think we agree to use "Tap" rather than trace/tracing to prevent confusion with the industry standard terminology.
- Make sure we are consistent with using the term "Fluent Bit" in the text rather than "fluent-bit" or any other option.
- Split sentences on to their own lines as it is easier to review.
Can you just double check we have caught all tracing references and fluent-bit ones?
…ent-bit to Fluent Bit Signed-off-by: elenacbc <elena@calyptia.com>
Signed-off-by: elenacbc <elena@calyptia.com>
lecaros
requested changes
Oct 20, 2022
…gestions Signed-off-by: elenacbc <elena@calyptia.com>
Signed-off-by: elenacbc <elena@calyptia.com>
Signed-off-by: elenacbc <elena@calyptia.com>
Thanks for your contribution @elenacbc! I've merged it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.