Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

administration: add troubleshooting including tap functionality #929

Merged
merged 22 commits into from
Oct 21, 2022

Conversation

elenacbc
Copy link
Contributor

No description provided.

…m source

Signed-off-by: elenacbc <elena@calyptia.com>
Signed-off-by: elenacbc <elena@calyptia.com>
elenacbc and others added 11 commits October 18, 2022 15:18
Signed-off-by: elenacbc <elena@calyptia.com>
Signed-off-by: elenacbc <elena@calyptia.com>
Signed-off-by: elenacbc <elena@calyptia.com>
Signed-off-by: elenacbc <elena@calyptia.com>
…ernals-signal

Signed-off-by: elenacbc <elena@calyptia.com>
Signed-off-by: elenacbc <elena@calyptia.com>
…-signal

Signed-off-by: elenacbc <elena@calyptia.com>
Signed-off-by: elenacbc <elena@calyptia.com>
…and added fluent-bit image

Signed-off-by: elenacbc <elena@calyptia.com>
Signed-off-by: elenacbc <elena@calyptia.com>
@elenacbc elenacbc changed the title Tap doc administration: add troubleshooting including tap functionality Oct 20, 2022
Copy link
Contributor

@patrick-stephens patrick-stephens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but a few things I think need covering:

  • I think we agree to use "Tap" rather than trace/tracing to prevent confusion with the industry standard terminology.
  • Make sure we are consistent with using the term "Fluent Bit" in the text rather than "fluent-bit" or any other option.
  • Split sentences on to their own lines as it is easier to review.

Can you just double check we have caught all tracing references and fluent-bit ones?

administration/monitoring.md Outdated Show resolved Hide resolved
administration/troubleshooting.md Outdated Show resolved Hide resolved
administration/troubleshooting.md Outdated Show resolved Hide resolved
administration/troubleshooting.md Outdated Show resolved Hide resolved
administration/troubleshooting.md Outdated Show resolved Hide resolved
administration/troubleshooting.md Outdated Show resolved Hide resolved
administration/troubleshooting.md Outdated Show resolved Hide resolved
administration/troubleshooting.md Outdated Show resolved Hide resolved
administration/troubleshooting.md Outdated Show resolved Hide resolved
administration/troubleshooting.md Outdated Show resolved Hide resolved
…ent-bit to Fluent Bit

Signed-off-by: elenacbc <elena@calyptia.com>
Signed-off-by: elenacbc <elena@calyptia.com>
administration/troubleshooting.md Outdated Show resolved Hide resolved
administration/troubleshooting.md Outdated Show resolved Hide resolved
administration/troubleshooting.md Outdated Show resolved Hide resolved
administration/troubleshooting.md Outdated Show resolved Hide resolved
administration/troubleshooting.md Outdated Show resolved Hide resolved
administration/troubleshooting.md Outdated Show resolved Hide resolved
administration/troubleshooting.md Outdated Show resolved Hide resolved
administration/troubleshooting.md Outdated Show resolved Hide resolved
administration/troubleshooting.md Show resolved Hide resolved
@lecaros lecaros merged commit b101992 into fluent:master Oct 21, 2022
@lecaros
Copy link
Contributor

lecaros commented Oct 21, 2022

Thanks for your contribution @elenacbc! I've merged it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants