Skip to content

Conversation

@heartrobotninja
Copy link
Contributor

for fluent/fluent-bit#2944

Signed-off-by: Joey DeStefanis jdestefanis@google.com

Signed-off-by: Joey DeStefanis <jdestefanis@google.com>
Signed-off-by: Joey DeStefanis <jdestefanis@google.com>
Signed-off-by: Joey DeStefanis <jdestefanis@google.com>
Signed-off-by: Joey DeStefanis <jdestefanis@google.com>
Signed-off-by: Joey DeStefanis <jdestefanis@google.com>
@heartrobotninja
Copy link
Contributor Author

@edsiper Here is the documentation for the stackdriver metadata merge.

Copy link

@igorpeshansky igorpeshansky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A minor nit.

| google\_service\_credentials | Absolute path to a Google Cloud credentials JSON file | Value of environment variable _$GOOGLE\_SERVICE\_CREDENTIALS_ |
| service\_account\_email | Account email associated to the service. Only available if **no credentials file** has been provided. | Value of environment variable _$SERVICE\_ACCOUNT\_EMAIL_ |
| service\_account\_secret | Private key content associated with the service account. Only available if **no credentials file** has been provided. | Value of environment variable _$SERVICE\_ACCOUNT\_SECRET_ |
| metadata\_server | Prefix for a metadata server. Can also set environment variable _$METADATA\_SERVER_ | http://metadata.google.internal |

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When the description is multiple sentences, there's a trailing period.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

Signed-off-by: Joey DeStefanis <jdestefanis@google.com>
Copy link

@igorpeshansky igorpeshansky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@edsiper edsiper merged commit f4edb9e into fluent:master Feb 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants