-
Notifications
You must be signed in to change notification settings - Fork 543
out_stackdriver: Document metadata_server_url config option #444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Joey DeStefanis <jdestefanis@google.com>
Signed-off-by: Joey DeStefanis <jdestefanis@google.com>
Signed-off-by: Joey DeStefanis <jdestefanis@google.com>
Signed-off-by: Joey DeStefanis <jdestefanis@google.com>
Signed-off-by: Joey DeStefanis <jdestefanis@google.com>
|
@edsiper Here is the documentation for the stackdriver metadata merge. |
igorpeshansky
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A minor nit.
pipeline/outputs/stackdriver.md
Outdated
| | google\_service\_credentials | Absolute path to a Google Cloud credentials JSON file | Value of environment variable _$GOOGLE\_SERVICE\_CREDENTIALS_ | | ||
| | service\_account\_email | Account email associated to the service. Only available if **no credentials file** has been provided. | Value of environment variable _$SERVICE\_ACCOUNT\_EMAIL_ | | ||
| | service\_account\_secret | Private key content associated with the service account. Only available if **no credentials file** has been provided. | Value of environment variable _$SERVICE\_ACCOUNT\_SECRET_ | | ||
| | metadata\_server | Prefix for a metadata server. Can also set environment variable _$METADATA\_SERVER_ | http://metadata.google.internal | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When the description is multiple sentences, there's a trailing period.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
Signed-off-by: Joey DeStefanis <jdestefanis@google.com>
igorpeshansky
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ![]()
for fluent/fluent-bit#2944
Signed-off-by: Joey DeStefanis jdestefanis@google.com