Supports authencation with service account on Google Compute Engine. #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a new configuration option "auth_method" to choose authentication method.
| @@ -113,13 +118,29 @@ class BigQueryOutput < BufferedOutput | |||
| def initialize | |||
| super | |||
| require 'google/api_client' | |||
| require 'google/api_client/client_secrets' | |||
| require 'google/api_client/auth/installed_app' | |||
| case @auth_method | |||
There was a problem hiding this comment.
@auth_method is not initialized yet here, isn't it?
Plugin#initialize runs before #configure.
There was a problem hiding this comment.
Done.
Maybe it's better to keep the code simple rather than require in configure().
|
LGTM! |
|
Ah, OK. |
tagomoris
added a commit
that referenced
this pull request
Feb 6, 2014
Supports authencation with service account on Google Compute Engine.
|
Thank you for contribution. |
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new configuration option "auth_method" to choose
authentication method.
Hello Tagomoris,
This is the patch I talked about. Since google-api-client gem 0.7.1 was shipped as a stable version, you can merge this change into master instead of keeping it in a separated branch if you want.