Skip to content

Commit

Permalink
add developer notes (#74)
Browse files Browse the repository at this point in the history
  • Loading branch information
mikevoronov authored Apr 26, 2022
1 parent 7924cb2 commit 6d73ae7
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions docs/developer-notes.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
In marine-rs-sdk we use the following conventions for PR reviewing:
- **Concept ACK** - agree with the idea and overall concept, but haven't reviewed the code changes or tested them,
- **utACK (untested ACK)** - reviewed and agree with the code changes but haven't actually tested them,
- **Tested ACK** - reviewed the code changes and have verified the functionality or a bug fix,
- **NACK** - disagree with the code changes/concept, should be accompanied by an explanation.

0 comments on commit 6d73ae7

Please sign in to comment.