-
Notifications
You must be signed in to change notification settings - Fork 3
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
1 parent
7924cb2
commit 6d73ae7
Showing
1 changed file
with
5 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
In marine-rs-sdk we use the following conventions for PR reviewing: | ||
- **Concept ACK** - agree with the idea and overall concept, but haven't reviewed the code changes or tested them, | ||
- **utACK (untested ACK)** - reviewed and agree with the code changes but haven't actually tested them, | ||
- **Tested ACK** - reviewed the code changes and have verified the functionality or a bug fix, | ||
- **NACK** - disagree with the code changes/concept, should be accompanied by an explanation. |