This repository was archived by the owner on Jul 10, 2025. It is now read-only.
[WIP] Added PureCodec examples #9
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xdralex
commented
Jun 13, 2018
|
|
||
|
|
||
| // To handle exceptions automatically, we can use Try monad. Note that we get `EitherT(Failure(...))`, not | ||
| // `EitherT(Failure(Right(...)))` as one might expect by analogy with previous examples. It's not |
There was a problem hiding this comment.
TBH I'm not sure why this happens and it's pretty confusing to say the least.
added 2 commits
June 13, 2018 16:21
xdralex
commented
Jun 13, 2018
| } | ||
|
|
||
|
|
||
| // TODO: describe `runF` and `toKleisli` |
There was a problem hiding this comment.
Actually, it seems the runF example quoted on the readme page is off. When I've tried to use runF accordingly to it, the compilation error has occurred. The code was:
val x = str2intCodec.direct.runF[Id]("foo")
println(x)
The error was:
[error] /Users/xdralex/Work/fluence/codec/examples/src/main/scala/fluence/codec/examples/PureCodecExample.scala:55:41: could not find implicit value for parameter F: cats.MonadError[cats.Id, _ >: fluence.codec.CodecError]
[error] val x = str2intCodec.direct.runF[Id]("foo")
[error] ^
[error] one error found
Not sure how the correct usage pattern should look like.
xdralex
commented
Jun 14, 2018
| val codecs: KryoCodecs[Task, ::[Fuel, ::[Aircraft, ::[Array[Byte], ::[Long, ::[String, HNil]]]]]] = KryoCodecs() | ||
| .addCase(classOf[Aircraft]) | ||
| .add[Fuel] | ||
| .build[Task]() |
There was a problem hiding this comment.
I am not sure how this Task affects things later on.
Doesn't look like it's going to be pushed as a monad into the codecs being built...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.