Skip to content

BufAudioTransport now has A-B based arguments #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 8, 2022

Conversation

tedmoore
Copy link
Member

@tedmoore tedmoore commented Feb 7, 2022

Because this affects (at least) 3 of our repos, I thought it would be good to get everyone's eyes over it!

This converts BufAudioTransport's arguments to an A/B based system for the two input buffers. I tested this and it all seems to be working great.

In response to: #66
Parallel to:

Screenshot 2022-02-07 at 15 19 29

@jamesb93 jamesb93 added this to the YAML to RST milestone Feb 8, 2022
@tremblap
Copy link
Member

tremblap commented Feb 8, 2022

the only file in Max and Pd using this is the helpfile of fluid.bufaudiotransport(~) that will need changing

@tedmoore
Copy link
Member Author

tedmoore commented Feb 8, 2022

the only file in Max and Pd using this is the helpfile of fluid.bufaudiotransport(~) that will need changing

Will this merge break that or just cause some incorrect documentation? Should that file be changed before a merge?

@tremblap
Copy link
Member

tremblap commented Feb 8, 2022

when we merge, that help file's code will break as their names attributes are in the instantiation of the objects. We just need to remember to do them when we merge, as a direct push on dev

@jamesb93
Copy link
Member

jamesb93 commented Feb 8, 2022

when we merge, that help file's code will break as their names attributes are in the instantiation of the objects. We just need to remember to do them when we merge, as a direct push on dev

We should set up a PR now that can be merged straight after merging this. Happy to do that.

@jamesb93
Copy link
Member

jamesb93 commented Feb 8, 2022

I've set up a PR to go after the PR to core is merged:

flucoma/flucoma-max#131

@tedmoore
Copy link
Member Author

tedmoore commented Feb 8, 2022

I've set up a PR to go after the PR to core is merged:

flucoma/flucoma-max#131

this is cool. Can you be made for Pd as well? ❤️ 🙏 🕺

@jamesb93
Copy link
Member

jamesb93 commented Feb 8, 2022

I've set up a PR to go after the PR to core is merged:
flucoma/flucoma-max#131

this is cool. Can you be made for Pd as well? ❤️ 🙏 🕺

Sure!

@jamesb93
Copy link
Member

jamesb93 commented Feb 8, 2022

Done:

flucoma/flucoma-pd#26

@tedmoore
Copy link
Member Author

tedmoore commented Feb 8, 2022

ok here we go

@tedmoore tedmoore merged commit 2166aa9 into dev Feb 8, 2022
@tedmoore tedmoore deleted the rename-AudioTransport-args branch February 8, 2022 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants