-
Notifications
You must be signed in to change notification settings - Fork 10
BufAudioTransport now has A-B based arguments #69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
the only file in Max and Pd using this is the helpfile of fluid.bufaudiotransport(~) that will need changing |
Will this merge break that or just cause some incorrect documentation? Should that file be changed before a merge? |
when we merge, that help file's code will break as their names attributes are in the instantiation of the objects. We just need to remember to do them when we merge, as a direct push on dev |
We should set up a PR now that can be merged straight after merging this. Happy to do that. |
I've set up a PR to go after the PR to core is merged: |
this is cool. Can you be made for Pd as well? ❤️ 🙏 🕺 |
Sure! |
Done: |
ok here we go |
Because this affects (at least) 3 of our repos, I thought it would be good to get everyone's eyes over it!
This converts BufAudioTransport's arguments to an A/B based system for the two input buffers. I tested this and it all seems to be working great.
In response to: #66
Parallel to: