Skip to content

Add local + core commit SHAs to version string #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 24, 2021

Conversation

weefuzzy
Copy link
Member

This uses git log to retrieve abbreviated SHAs for flucoma-core and the project being built, and appends them to the version string.

I've used the semantic versioning guidelines for including build meta data

Build metadata MAY be denoted by appending a plus sign and a series of dot separated identifiers immediately following the patch or pre-release version. Identifiers MUST comprise only ASCII alphanumerics and hyphens [0-9A-Za-z-]. Identifiers MUST NOT be empty. Build metadata MUST be ignored when determining version precedence. Thus two versions that differ only in the build metadata, have the same precedence. Examples: 1.0.0-alpha+001, 1.0.0+20130313144700, 1.0.0-beta+exp.sha.5114f85, 1.0.0+21AF26D3—-117B344092BD.

@weefuzzy weefuzzy added the enhancement New feature or request label Nov 16, 2021
@weefuzzy weefuzzy requested a review from jamesb93 November 16, 2021 00:01
@weefuzzy weefuzzy self-assigned this Nov 16, 2021
@jamesb93
Copy link
Member

This is gorgeous work:

image

Thanks for sorting this business out.

@jamesb93 jamesb93 merged commit eb6e780 into flucoma:dev Nov 24, 2021
@weefuzzy weefuzzy deleted the enhance/version-sha branch April 8, 2025 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants