feat: avoid adding unnecessary package.patterns property to functions #474
+63
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
floydspace
approved these changes
Jul 11, 2023
Owner
floydspace
left a comment
floydspace
left a comment
There was a problem hiding this comment.
@tvhees thank you. looks good
|
🎉 This PR is included in version 1.46.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Serverless v3.32.0 added a warning when encountering
package.patternson a function ifservice.package.individuallyis not set totrue:https://github.com/serverless/serverless/releases/tag/v3.32.0
This warning is being emitted when esbuild is used to package a service because the plugin defaults to adding an empty array for
package.patternsto every function. The core serverless code does not expect this property to be there unless specified in configuration and the plugin should match this behaviour.