Skip to content

Conversation

@godu
Copy link
Contributor

@godu godu commented Jul 21, 2025

Adds support for dsql. This service need dsql-signer package to generate an authentication token.

@changeset-bot
Copy link

changeset-bot bot commented Jul 21, 2025

🦋 Changeset detected

Latest commit: 2bea8e9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@effect-aws/client-dsql Major
@effect-aws/dsql Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@floydspace
Copy link
Owner

thanks, @godu, lemme check

@godu
Copy link
Contributor Author

godu commented Jul 21, 2025

Let me fix the CI first :)

@godu godu force-pushed the dsql branch 4 times, most recently from 5c78d8c to 4590221 Compare July 21, 2025 18:49
@floydspace
Copy link
Owner

floydspace commented Jul 27, 2025

hi @godu
I took time to review the PR, generated code looked good
I made some fixes though:

  • updated all @AWS-SDK dependencies to latest , so no duplicates presented
  • I renamed the dsql-signer lib to just dsql to be consistent with other halper libs, like s3, dynamodb, and etc... The idea is having a single helper lib per client, which implements some additional custom modules, DsqlSigner could be just a sub module of such helper lib...
  • start @effect-aws/dsql version from 0.1.0, I believe when libs are still not documented and adopted enough they should start with v0
  • and I refactored a bit the service, no need defaultLayer, as the signer config is not optional and host must be anyway provided, so having chain of layers is not a good DX

@floydspace floydspace merged commit 5fc52b9 into floydspace:main Jul 27, 2025
7 checks passed
@github-actions github-actions bot mentioned this pull request Jul 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants