Infer types for constant expressions #1535
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EagleoutIce
reviewed
Apr 6, 2025
| } | ||
|
|
||
| override foldRString(_node: RString<Info>): TypingInfo { | ||
| return RDataType.String; |
There was a problem hiding this comment.
Just as food for thought: do you want to tag raw strings specifically in the future?
| } | ||
|
|
||
| override foldRNumber(_node: RNumber<Info>): TypingInfo { | ||
| return RDataType.Numeric; |
There was a problem hiding this comment.
You should do the complex recognition here if you want to separate 1i from 1.
Additionally: How do you want to map values such as NA, NaN etc.?
EagleoutIce
approved these changes
Apr 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will add type inference for logical, numeric and string constants 😎