Energy class for inventorying multiple energy models #944
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liljonnystyle
requested review from
AboudyKreidieh,
cathywu,
eugenevinitsky and
kanaadp
as code owners
liljonnystyle
commented
May 22, 2020
This python file describes the base energy file which will serve as the parent class of the power demand model and toyota energy models.
applied comments from from previous PR.
These are child classes of the base_energy class.
liljonnystyle
commented
May 27, 2020
Some imports removed
added space after all commas
this code is actually unrelated to the energy classes being implemented, but rather the fuel consumption from SUMO
liljonnystyle
commented
May 30, 2020
liljonnystyle
commented
May 30, 2020
liljonnystyle
commented
May 30, 2020
Updated traci.py, params.py and rewards.py
liljonnystyle
commented
Jun 24, 2020
There was a problem hiding this comment.
looking good, mostly pretty minor changes now:
- all the changes to traci.py can be reverted, except for
_add_departed()andget_power() get_power()needs to be added to the base vehicle class as an abstractmethod- docstrings need to be updated
- some minor stylistic changes
kjang96
requested changes
Jun 30, 2020
kjang96
requested changes
Jun 30, 2020
There was a problem hiding this comment.
Left a couple more nits. Also please make sure you run the code for all energy models and make sure they're working. By this, I mean, go into exp_configs, and make sure that the code runs when you add vehicles of all the kinds of energy models that you have specified
liljonnystyle
commented
Jul 2, 2020
…into jc-energy-class
…jc-energy-class
…jc-energy-class
kjang96
requested changes
Jul 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request information
Description
This is a new implementation of a base energy class along with a few child classes to help us inventory the multiple energy models we plan to have.
@liljonnystyle is uploading on behalf of @joyncarpio to initiate tracking of code changes.