New way to install flow #62
Conversation
Add a Dockerfile that can run with a desktop on your browser with every flow packages installed
lucfisc
requested review from
AboudyKreidieh,
cathywu,
eugenevinitsky and
kanaadp
as code owners
|
Looks good so far, I'll check out if it works in a bit. A few comments though:
|
|
+1, we should clarify local installation vs. non-local installation and ensure that developers install the local install |
|
Actually, @lucfisc can u replace the table of contents with this? |
|
@AboudyKreidieh Done |
docs/source/flow_setup.rst
Outdated
| Setup Instructions | ||
| .. contents:: Table of contents | ||
|
|
||
| 1 - Local Installation |
There was a problem hiding this comment.
The numbering scheme here is different than the numbering scheme below. Is this correct @lucfisc
| 1° Go to http://localhost:6901/?password=vncpassword | ||
| 2° Go to Applications and open Terminal Emulator | ||
| 3° For sumo: Write python flow/examples/sumo/sugiyama.py and run it | ||
| 4° For rllib : Write python flow/examples/rllib/stabilizing_the_ring.py and run it |
There was a problem hiding this comment.
so rllib is not installed in a virtual env but rllab is?
There was a problem hiding this comment.
@eugenevinitsky. Rllib is installed in the root environment and works.
For rllab, I need to enter another environment ( flow-rllab) but I am working on a way to have everything set up in the same environment
There was a problem hiding this comment.
Okay, should be good to go after this. Can you add the dockerfile that you used to create the docker image? Would be useful to have in the docker folder as a record if we need to remake it!
|
A few more minor comments, almost there! |
docs/source/flow_setup.rst
Outdated
|
|
||
| 2- Remote desktop using Docker (recommended for testing purpose) | ||
| a. Installation | ||
| b. Notebooks and tutorial |
There was a problem hiding this comment.
.. contents: will actually automatically generate the table of contents, so no need for this anymore
There was a problem hiding this comment.
@AboudyKreidieh Deleted it, will know for the next time ! Thanks for your help
docs/source/flow_setup.rst
Outdated
| ==================== | ||
|
|
||
| You may define user-specific config parameters as follows | ||
| :: | ||
|
|
||
| cp flow/core/config.template.py flow/core/config.py # Create template for users using pycharm | ||
|
|
||
|
|
||
| Remote desktop using Docker for simple utilisation of flow (recommended for testing purpose) |
Changes in the table of content to make it work
Docker file to install the remote desktop
|
Added the dockerfile, publish the docker to the docker hub. RLLIB is installed, RLLAB is installed , FLOW is installed. Documentation is up to date |
Added two lines in order to solver the merging conflict I had
|
Thanks! Just to check, @lucfisc , ready to merge? |
New way to install flow
Add a Dockerfile that can run with a desktop on your browser with every flow packages installed and ready to use