Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved displaying floats as strings #1030

Merged
merged 1 commit into from
Mar 29, 2024
Merged

Improved displaying floats as strings #1030

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/core/etl/src/Flow/ETL/Row/Entry/FloatEntry.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,13 @@ public function rename(string $name) : Entry

public function toString() : string
{
return (string) $this->value();
$float = (string) $this->value();

if (!\str_contains($float, '.')) {
$float .= '.00';
}

return $float;
}

public function type() : Type
Expand Down
8 changes: 4 additions & 4 deletions src/lib/parquet-viewer/tests/Flow/ParquetViewer/Tests/Integration/ReadDataCommandTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,13 +34,13 @@ public function test_read_data_command() : void
| true | 601197183 | 1252452733354460846 | 10.25 | 0.3608 | 458.7799988 | Et itaque beatae sun | 2023-08-16T00:00:00+ | 2023-07-18T01:27:45+ | [{"date":"2023-08-09 | {"a":15173348,"b":19 | ["Ea quia ut numquam | {"id":1,"name":"name |
| true | 1898860246 | 80604967340828891 | 10.25 | 327433.40625 | 3284.8200684 | Et consequuntur maio | 2023-09-23T00:00:00+ | 2023-02-05T16:56:28+ | [{"date":"2023-09-30 | {"a":1533619681,"b": | ["Debitis fugiat com | {"id":2,"name":"name |
| false | 1315048828 | 3129070533160172325 | 10.25 | 2203746.75 | 569329.1875 | Aut est optio earum | 2023-05-30T00:00:00+ | 2023-07-15T05:24:48+ | [{"date":"2023-03-31 | {"a":1749103854,"b": | ["Non voluptates aut | {"id":3,"name":"name |
| false | 1558719417 | 6878707872420020635 | 10.25 | 1.6939 | 25955398 | Dolorem magnam qui d | 2023-08-13T00:00:00+ | 2023-03-24T21:14:45+ | [{"date":"2023-01-09 | {"a":1720840905,"b": | ["Nihil quod perspic | {"id":4,"name":"name |
| false | 1558719417 | 6878707872420020635 | 10.25 | 1.6939 | 25955398.00 | Dolorem magnam qui d | 2023-08-13T00:00:00+ | 2023-03-24T21:14:45+ | [{"date":"2023-01-09 | {"a":1720840905,"b": | ["Nihil quod perspic | {"id":4,"name":"name |
| true | 1012067503 | 8967249410708780846 | 10.25 | 1750536.875 | 8.25 | Aut velit alias enim | 2023-10-16T00:00:00+ | 2023-10-05T18:39:53+ | [{"date":"2023-01-01 | {"a":811892167,"b":9 | ["Voluptas eos quisq | {"id":5,"name":"name |
| true | 28238480 | 3652472020703415644 | 10.25 | 22556.65625 | 41735.0507813 | Ipsam voluptatem ips | 2023-05-15T00:00:00+ | 2023-06-22T00:51:17+ | [{"date":"2023-05-11 | {"a":2124941571,"b": | ["Ut sed debitis del | {"id":6,"name":"name |
| true | 1294233247 | 7357477648138228591 | 10.25 | 237157 | 185585584 | Voluptas itaque cupi | 2023-01-09T00:00:00+ | 2023-08-09T21:26:24+ | [{"date":"2023-09-04 | {"a":429815988,"b":1 | ["Nihil modi volupta | {"id":7,"name":"name |
| false | 1250913218 | 7983709812438780296 | 10.25 | 25667990 | 3079052.75 | Minus autem est eos | 2023-07-10T00:00:00+ | 2023-08-28T18:12:31+ | [{"date":"2023-02-03 | {"a":412214284,"b":7 | ["Consectetur nobis | {"id":8,"name":"name |
| true | 1294233247 | 7357477648138228591 | 10.25 | 237157.00 | 185585584.00 | Voluptas itaque cupi | 2023-01-09T00:00:00+ | 2023-08-09T21:26:24+ | [{"date":"2023-09-04 | {"a":429815988,"b":1 | ["Nihil modi volupta | {"id":7,"name":"name |
| false | 1250913218 | 7983709812438780296 | 10.25 | 25667990.00 | 3079052.75 | Minus autem est eos | 2023-07-10T00:00:00+ | 2023-08-28T18:12:31+ | [{"date":"2023-02-03 | {"a":412214284,"b":7 | ["Consectetur nobis | {"id":8,"name":"name |
| true | 2105356816 | 8855288021139833847 | 10.25 | 0.93007 | 2433.8400879 | Fuga aut rerum et de | 2023-08-21T00:00:00+ | 2023-03-27T19:05:04+ | [{"date":"2023-02-07 | {"a":1268800792,"b": | ["Labore ratione sun | {"id":9,"name":"name |
| true | 1314291690 | 7670636630642412419 | 10.25 | 73.3677063 | 20244592 | Voluptate non sit am | 2023-10-07T00:00:00+ | 2023-09-15T08:41:32+ | [{"date":"2023-05-25 | {"a":929312481,"b":2 | ["Iusto quam et est | {"id":10,"name":"nam |
| true | 1314291690 | 7670636630642412419 | 10.25 | 73.3677063 | 20244592.00 | Voluptate non sit am | 2023-10-07T00:00:00+ | 2023-09-15T08:41:32+ | [{"date":"2023-05-25 | {"a":929312481,"b":2 | ["Iusto quam et est | {"id":10,"name":"nam |
+---------+------------+---------------------+-------+--------------+---------------+----------------------+----------------------+----------------------+----------------------+----------------------+----------------------+----------------------+
10 rows
OUTPUT,
Expand Down
Loading