Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Guillotina #41

Merged
merged 1 commit into from
Jul 29, 2020
Merged

Conversation

masipcat
Copy link
Contributor

Checklist

  • This project is explicitly related to ASGI.
  • The new list entry contains a project name, URL and description.
  • Alphabetical order is preserved across entries and sections.

What is this project?

  • Guillotina - Guillotina is the only full-featured Python AsyncIO REST Resource Application Server designed for high-performance, horizontally scaling solutions.

Do you know about other similar projects?

No

If so, how is this one different?


Anyone who agrees with this pull request can add a 👍.

@florimondmanca
Copy link
Owner

florimondmanca commented Jun 19, 2020

Heya,

Woah, that's a lot of 👍 already. 😄

Not being familiar with this project myself, can you point me to the docs page or other resources that mentions this framework is ASGI compatible? I was not able to grep through the docs (the search page doesn't load up). If it's not actually compatible with ASGI, it may be a better entry for awesome-asyncio.

Cheers

@masipcat
Copy link
Contributor Author

masipcat commented Jun 19, 2020

the documentation hosted in readthedocs still points to 5.x version (and that version was based on top of aiohttp), but you can see here that 6.x implements ASGI: https://github.com/plone/guillotina/blob/618c6707c65520536753d14f9c22157659fd6b88/docs/source/developer/advanced.md#advanced

@masipcat
Copy link
Contributor Author

Documentation updated! You can see in https://guillotina.readthedocs.io/en/latest/#build-a-guillotina-app that guillotina uses uvicorn

Copy link
Owner

@florimondmanca florimondmanca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update!

README.md Outdated
@@ -39,6 +39,7 @@ _Frameworks for building ASGI web applications._
- [Channels](https://channels.readthedocs.io/en/latest/) - Asynchronous support for Django, and the original driving force behind the ASGI project. Supports HTTP and WebSockets with Django integration, and any protocol with ASGI-native code.
- [Django](https://docs.djangoproject.com/en/3.0/topics/async/) - The web framework for perfectionists with deadlines. Has native ASGI support since version 3.0.
- [FastAPI](https://github.com/tiangolo/fastapi) - A modern, high-performance web framework for building APIs with Python 3.6+ based on standard Python type hints. Powered by Starlette and Pydantic. Supports HTTP and WebSockets.
- [Guillotina](https://github.com/plone/guillotina) - Guillotina is the only full-featured Python AsyncIO REST Resource Application Server designed for high-performance, horizontally scaling solutions.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion to tune boilerplate down a bit and clarify how this relates to ASGI:

Full-featured ASGI-compatible REST application framework, designed for high performance and horizontally scaling solutions.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done :)

Copy link
Owner

@florimondmanca florimondmanca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@florimondmanca florimondmanca merged commit 7d79dab into florimondmanca:master Jul 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants