Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrated Eureka service discovery. #61

Merged
merged 10 commits into from
Sep 9, 2023
Merged

Integrated Eureka service discovery. #61

merged 10 commits into from
Sep 9, 2023

Conversation

cybwan
Copy link
Collaborator

@cybwan cybwan commented Sep 9, 2023

Description:
Integrated Eureka service discovery.

Testing done:
Done

Affected area:

Functional Area
New Functionality [X]
CI System [ ]
CLI Tool [ ]
Certificate Management [ ]
Control Plane [ ]
Demo [ ]
Documentation [ ]
Egress [ ]
Ingress [ ]
Install [ ]
Networking [ ]
Observability [ ]
Performance [ ]
SMI Policy [ ]
Security [ ]
Sidecar Injection [ ]
Tests [ ]
Upgrade [ ]
Other [ ]

Please answer the following questions with yes/no.

  1. Does this change contain code from or inspired by another project? no

  2. Is this a breaking change? no

  3. Has documentation corresponding to this change been updated in the fsm-docs repo (if applicable)? no

@codecov-commenter
Copy link

codecov-commenter commented Sep 9, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01% ⚠️

Comparison is base (ac023a9) 48.57% compared to head (cfe664e) 48.57%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #61      +/-   ##
==========================================
- Coverage   48.57%   48.57%   -0.01%     
==========================================
  Files         194      194              
  Lines       14480    14477       -3     
==========================================
- Hits         7034     7032       -2     
+ Misses       7403     7402       -1     
  Partials       43       43              
Flag Coverage Δ
unittests 48.57% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
cmd/fsm-controller/fsm-controller.go 12.64% <ø> (-0.44%) ⬇️
pkg/errcode/errcode.go 100.00% <ø> (ø)
pkg/sidecar/providers/pipy/registry/services.go 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@reaver-flomesh reaver-flomesh added the enhancement New feature or request label Sep 9, 2023
@reaver-flomesh reaver-flomesh added this to the v1.1.1 milestone Sep 9, 2023
@reaver-flomesh reaver-flomesh merged commit d35dd38 into flomesh-io:main Sep 9, 2023
26 checks passed
reaver-flomesh added a commit that referenced this pull request Sep 9, 2023
* Integrated Eureka service discovery.

* Integrated Eureka service discovery.

* Integrated Eureka service discovery.

* Integrated Eureka service discovery.

* Integrated Eureka service discovery.

* Integrated Eureka service discovery.

* Integrated Eureka service discovery.

* Integrated Eureka service discovery.

* Integrated Eureka service discovery.

---------

Co-authored-by: Lin Yang <reaver@flomesh.io>
@cybwan cybwan deleted the release-v1.1.1-alpha.2 branch September 9, 2023 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants