Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor fsm-connector #133

Merged
merged 38 commits into from
Dec 1, 2023
Merged

refactor fsm-connector #133

merged 38 commits into from
Dec 1, 2023

Conversation

cybwan
Copy link
Collaborator

@cybwan cybwan commented Dec 1, 2023

Description:
refactor fsm-connector

Testing done:
DONE

Affected area:

Functional Area
New Functionality [X]
CI System [ ]
CLI Tool [ ]
Certificate Management [ ]
Control Plane [ ]
Demo [ ]
Documentation [ ]
Egress [ ]
Ingress [ ]
Install [ ]
Networking [ ]
Observability [ ]
Performance [ ]
SMI Policy [ ]
Security [ ]
Sidecar Injection [ ]
Tests [ ]
Upgrade [ ]
Other [ ]

Please answer the following questions with yes/no.

  1. Does this change contain code from or inspired by another project? no

  2. Is this a breaking change? no

  3. Has documentation corresponding to this change been updated in the fsm-docs repo (if applicable)? no

@codecov-commenter
Copy link

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (30e0f2e) 48.48% compared to head (f59ba7a) 48.47%.
Report is 5 commits behind head on release/v1.2.

Files Patch % Lines
pkg/k8s/util.go 0.00% 2 Missing ⚠️
pkg/sidecar/providers/pipy/registry/services.go 0.00% 2 Missing ⚠️
pkg/k8s/client.go 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@               Coverage Diff                @@
##           release/v1.2     #133      +/-   ##
================================================
- Coverage         48.48%   48.47%   -0.01%     
================================================
  Files               194      194              
  Lines             14614    14625      +11     
================================================
+ Hits               7085     7090       +5     
- Misses             7485     7491       +6     
  Partials             44       44              
Flag Coverage Δ
unittests 48.47% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

pkg/sidecar/providers/pipy/repo/jobs.go Dismissed Show dismissed Hide dismissed
@reaver-flomesh reaver-flomesh merged commit e2ac825 into flomesh-io:release/v1.2 Dec 1, 2023
25 of 26 checks passed
@cybwan cybwan deleted the release-v1.2.0-alpha.11 branch December 1, 2023 05:42
reaver-flomesh pushed a commit that referenced this pull request Dec 27, 2023
* traffic split based on eureka metadata

* refactor connector

* refactor connector

* refactor connector

* refactor connector

* refactor connector

* refactor fsm-connector

* refactor fsm-connector

* refactor fsm-connector

* refactor fsm-connector

* refactor fsm-connector

* refactor fsm-connector

* refactor fsm-connector

* refactor fsm-connector

* refactor fsm-connector

* refactor fsm-connector

* refactor fsm-connector

* refactor fsm-connector

* refactor fsm-connector

* refactor fsm-connector

* refactor fsm-connector

* refactor fsm-connector

* refactor fsm-connector

* refactor fsm-connector

* refactor fsm-connector

* refactor fsm-connector

* refactor fsm-connector

* refactor fsm-connector

* refactor fsm-connector

* refactor fsm-connector

* refactor fsm-connector

* refactor fsm-connector

* refactor fsm-connector

* refactor fsm-connector

* refactor fsm-connector

* refactor fsm-connector

* refactor fsm-connector

* refactor fsm-connector
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants