feat: add QR hardware wallet support#1757
Open
ethermachine wants to merge 7 commits intofloating:developfrom
Open
feat: add QR hardware wallet support#1757ethermachine wants to merge 7 commits intofloating:developfrom
ethermachine wants to merge 7 commits intofloating:developfrom
Conversation
Implement QR-based hardware wallet integration for airgapped signing: - Add QRSigner class with HD wallet address derivation (BIP44) - Implement UR (Uniform Resources) encoding/decoding for device communication - Add QR scanner component with camera permission handling - Create QR sign request overlay for transaction/message signing - Support animated QR codes for large payloads - Add device import via crypto-account sync QR codes - Integrate with existing signer infrastructure Supports Keycard Shell, Keystone, Ngrave, Ellipal, and other compatible QR hardware wallets.
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
- Change label from 'QR Hardware (Keystone)' to 'QR Device' for clarity. - Refactor conditional statement for hardware signers to enhance readability by formatting it across multiple lines.
- Simplify JSX structure in AddHardwareQR component by merging div elements. - Enhance error handling display in QRScanner and QRSignRequest components for better readability. - Standardize logging format in QRSignerAdapter for consistency. - Clean up signature parsing in ur-utils for improved clarity.
…a, normalizing signature `v` values, and enhancing QR code display and encoding.
…on details and update signer management to use it, along with new `accountSource` and `childrenPath` fields.
Remove double-encoding of message data in QR adapter. The message is
already hex-encoded, so passing it through Buffer.from().toString('hex')
was causing the QR device to sign incorrect data, leading to ecRecover
check failures.
…ancing signature verification with flipped recovery IDs for legacy transactions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Features
Test plan