Skip to content

allow php8 #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 24, 2020
Merged

allow php8 #51

merged 3 commits into from
Oct 24, 2020

Conversation

nick-zh
Copy link
Contributor

@nick-zh nick-zh commented Oct 19, 2020 •
edited
Loading

@tPl0ch let me know if you want to include CI changes as well (nighly build until PHP8 is out), i can adjust .travis.yml accordingly

@nick-zh
Copy link
Contributor Author

nick-zh commented Oct 20, 2020

@tPl0ch i added 2 jobs for nightly. I can't add it to the matrix yet (also for avro-serde), since php-cs-fixer is not yet php:8 compatible. Once this is merged, i can adapt avro-serde with a similar approach. I hope this is ok.
As soon as PHP8 is out i will create a PR to replace nightly (currently 8rc) with the official php:8 version

@nick-zh nick-zh mentioned this pull request Oct 24, 2020
Closed
@tPl0ch tPl0ch merged commit 37ee2ee into flix-tech:master Oct 24, 2020
tPl0ch pushed a commit that referenced this pull request Oct 29, 2020
@nick-zh @tPl0ch
allow php8 (#51)
9e30414 
* allow php8
* add nightly (8rc)
* adjust ci
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nick-zh @tPl0ch