Skip to content

Add support for psr cache interfaces #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 1, 2020

Conversation

xico42
Copy link
Contributor

@xico42 xico42 commented Oct 1, 2020

This PR adds support for the PSR cache interfaces.

This adds up a lot of possibilities and flexibility regarding caching options to the package, for example, the symfony/cache project (that implements the interfaces) provides us with at least 12 adapters. Not to mention all the others implementations of this standard.

Besides PSR-6, I've also implemented the adapter for PSR-16 (SimpleCache).

@xico42
Copy link
Contributor Author

xico42 commented Oct 1, 2020

If possible, I would like some help with the failing tests. The same tests breaking here, seem to be breaking in the master branch as well.

 * Add support for psr-6 with the CacheItemPoolAdapter
 * Add support for psr-16 with the SimpleCacheAdapter
 * The package guzzlehttp/psr7 from version 1.7 breaks the tests, so
 constraint it at version <1.7
Copy link
Collaborator

@tPl0ch tPl0ch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tPl0ch tPl0ch merged commit 02f0db9 into flix-tech:master Oct 1, 2020
@tPl0ch
Copy link
Collaborator

tPl0ch commented Oct 1, 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants