Remove ShortcutRecorder and Sparkle dependency until fixed #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yeah, definitely don't want to do this long term. But I really appreciate you creating a PR. With some free time coming up hopefully I can fix the signing properly. |
|
This change was moved to the bugfix/big_sur branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the dependencies own ShortcutRecorder and Sparkle which cause the app to not start on macOS 11 Big Sur. The issue is due to signing, but I was unable to get the right settings to work, so I punted and removed them. I doubt that this is the end goal, but maybe others can tweak to get the signing correct so Big Sur will load the libs at launch.