fix(cue): get error position using error path #2701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## test-cue-extended #2701 +/- ##
====================================================
Coverage ? 72.98%
====================================================
Files ? 85
Lines ? 8366
Branches ? 0
====================================================
Hits ? 6106
Misses ? 1882
Partials ? 378 ☔ View full report in Codecov by Sentry. |
markphelps
approved these changes
Jan 23, 2024
kodiakhq bot
pushed a commit
that referenced
this pull request
Jan 23, 2024
* chore: add tests for cue extended * fix(cue): get error position using error path (#2701) * fix(cue): get error position using error path * fix(cue): ensure we start by using the deapest path selector * test(storage/fs): update case now that errors point more appropriately into data --------- Co-authored-by: George <me@georgemac.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR on #2697
This attempts to walk through the path selector in the error, using it as an index into the source document.
It is an attempt to use the path to find the first found position and use that in the error context.