chore: deprecate jaeger #2675
Merged
chore: deprecate jaeger #2675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2675 +/- ##
==========================================
- Coverage 73.02% 72.99% -0.03%
==========================================
Files 85 85
Lines 8326 8325 -1
==========================================
- Hits 6080 6077 -3
- Misses 1869 1871 +2
Partials 377 377 ☔ View full report in Codecov by Sentry. |
GeorgeMac
reviewed
Jan 18, 2024
internal/config/tracing.go
Outdated
| @@ -22,11 +22,10 @@ type TracingConfig struct { | |||
| func (c *TracingConfig) setDefaults(v *viper.Viper) error { | |||
| v.SetDefault("tracing", map[string]any{ | |||
| "enabled": false, | |||
| "exporter": TracingJaeger, | |||
| "exporter": TracingOTLP, | |||
There was a problem hiding this comment.
Questioning this incase it wasn't considered:
Should we be simultaneously deprecating and changing the default behaviour like this?
Just wondering if there might be folks out there with solely:
tracing:
enabled: trueThat might just be relying on it talking to jaeger.
There was a problem hiding this comment.
good call. I also added a tracing section to telemetry so we can hopefully get more data about when its safe to fully remove
GeorgeMac
approved these changes
Jan 18, 2024
yquansah
approved these changes
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #2650