Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/feat: use joins instead of n+1/opening multiple connections #1297

Merged
merged 8 commits into from
Feb 1, 2023
Merged

fix/feat: use joins instead of n+1/opening multiple connections #1297

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
b3c2a43
chore: wip sqlite concurrency issue
markphelps Jan 27, 2023
1bf6fd1
chore: use left join to get flags/variants at same time
markphelps Jan 28, 2023
7797e39
chore: comments to clarify logic
markphelps Jan 28, 2023
bd84114
chore: finish joins
markphelps Jan 31, 2023
d8e27e2
chore: set maxopencons to 1 for sqlite
markphelps Jan 31, 2023
4d06f5e
chore: only disable CSP headers in development
markphelps Jan 31, 2023
a7d0c44
Update internal/storage/sql/db.go
markphelps Feb 1, 2023
56cf0fa
chore: log warning if overriding max_open_conn
markphelps Feb 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore: only disable CSP headers in development
  • Loading branch information
@markphelps
markphelps committed Jan 31, 2023
commit 4d06f5e9110b0d99b6ec2aa1c67a06ebe3ca4991
2 changes: 1 addition & 1 deletion internal/info/flipt.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ type Flipt struct {
}

func (f Flipt) IsDevelopment() bool {
return f.Version == "dev" && !f.IsRelease
return f.Version == "dev"
}

func (f Flipt) ServeHTTP(w http.ResponseWriter, r *http.Request) {
Expand Down