Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dont wipe out snapshot if error in parser #96

Merged
merged 3 commits into from
Jan 15, 2024
Merged

Conversation

markphelps
Copy link
Contributor

@markphelps markphelps commented Jan 15, 2024

Fixes: #95

  • Modifies the Snapshot::build to propagate any errors instead of returning an empty Document

We still swallow the error in replace_snapshot, and will need to figure out what we want to do here, likely something related to #60

This also returns an error on first call to new_snapshot_evaluator at engine initialization if it can't do the first call to get the snapshot from the API, which I think is likely the behavior we want for now

@markphelps markphelps requested a review from a team as a code owner January 15, 2024 21:41
Copy link
Contributor

@yquansah yquansah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah i think this is fine for now. We will figure out logging, and other error scenarios later on.

@markphelps markphelps merged commit 75850ab into main Jan 15, 2024
6 checks passed
@markphelps markphelps deleted the preserve-snapshot branch January 15, 2024 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FLI-777] Preserve previous snapshot if parser fails
2 participants