fix: dont wipe out snapshot if error in parser #96
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #95
Snapshot::build
to propagate any errors instead of returning an empty DocumentWe still swallow the error in
replace_snapshot
, and will need to figure out what we want to do here, likely something related to #60This also returns an error on first call to
new_snapshot_evaluator
at engine initialization if it can't do the first call to get the snapshot from the API, which I think is likely the behavior we want for now