feat: Package/windows #433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mark Phelps <209477+markphelps@users.noreply.github.com>
Signed-off-by: Mark Phelps <209477+markphelps@users.noreply.github.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #433 +/- ##
==========================================
+ Coverage 87.35% 87.42% +0.07%
==========================================
Files 9 9
Lines 3740 3737 -3
==========================================
Hits 3267 3267
+ Misses 473 470 -3 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Mark Phelps <209477+markphelps@users.noreply.github.com>
Signed-off-by: Mark Phelps <209477+markphelps@users.noreply.github.com>
Signed-off-by: Mark Phelps <209477+markphelps@users.noreply.github.com>
Signed-off-by: Mark Phelps <209477+markphelps@users.noreply.github.com>
Signed-off-by: Mark Phelps <209477+markphelps@users.noreply.github.com>
Signed-off-by: Mark Phelps <209477+markphelps@users.noreply.github.com>
…lient-sdks into package/windows * 'package/windows' of https://github.com/flipt-io/flipt-client-sdks: chore: bump browser sdk for release (#432)
Signed-off-by: Mark Phelps <209477+markphelps@users.noreply.github.com>
Signed-off-by: Mark Phelps <209477+markphelps@users.noreply.github.com>
erka
approved these changes
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re: #141 (comment)
This pull request introduces several changes to the build and packaging workflows, as well as updates to support Windows in various SDKs. The most important changes include adding support for Windows builds, modifying the workflows to handle different platforms, and updating the SDKs to accommodate these changes.
Workflow Updates:
.github/workflows/package-ffi-engine.yml.jobs:in.github/workflows/package-ffi-engine.yml..github/workflows/package-ffi-engine.yml.SDK Updates:
flipt-client-dart/lib/src/flipt_evaluation_client.dart.flipt-client-go/evaluation.go.flipt-client-python/flipt_client/__init__.py.flipt-client-ruby/lib/flipt_client.rb.Codebase Simplification:
package/ffi/main.go. [1] [2] [3]package/ffi/main.go. [1] [2]These changes ensure that the build and packaging workflows are more robust and can handle multiple platforms, including Windows, while simplifying the codebase for better maintainability.