Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add notification sending #3449

Merged
merged 2 commits into from
Feb 17, 2024
Merged

Add notification sending #3449

merged 2 commits into from
Feb 17, 2024

Conversation

drunkbatya
Copy link
Contributor

@drunkbatya drunkbatya commented Feb 14, 2024 •
edited by skotopes
Loading

What's new

  • Add sending firebase notifications on firmware release

Verification

  • Make release and check your phone

Checklist (For Reviewer)

  • PR has description of feature/bug or link to Confluence/Jira task
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 14, 2024 •
edited
Loading

Compiled f7 firmware for commit 93c6441e:

LionZXY
LionZXY approved these changes Feb 14, 2024
View reviewed changes
Copy link
Member

@LionZXY LionZXY left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you!

@drunkbatya drunkbatya marked this pull request as ready for review February 14, 2024 10:40
@skotopes skotopes merged commit fcf3b50 into dev Feb 17, 2024
9 checks passed
@skotopes skotopes deleted the drunkbatya/release-notifications branch February 17, 2024 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skotopes skotopes skotopes approved these changes

@LionZXY LionZXY LionZXY approved these changes

@DrZlo13 DrZlo13 Awaiting requested review from DrZlo13 DrZlo13 is a code owner

@hedger hedger Awaiting requested review from hedger hedger is a code owner

@gsurkov gsurkov Awaiting requested review from gsurkov gsurkov is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@drunkbatya @skotopes @LionZXY