Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lfrfid/em4100: added support for different bit rates #3410

Merged
merged 3 commits into from
Feb 15, 2024

Conversation

Mrkvak
Copy link
Contributor

@Mrkvak Mrkvak commented Jan 31, 2024

What's new

The current em4100 code supports only 64 clock cycles per bit.

This PR adds support for different bit rates (32 and 16), instead of default 64 clock cycles per bit.
According to EM4100 datasheet available at https://docs.rs-online.com/6ee7/0900766b8161beae.pdf, used combinations are:

  • A6: Manchester 64cl/bit
  • A5: Manchester 32cl/bit
  • B6: Bi-phase 64cl/bit
  • B5: Bi-phase 32cl/bit
  • C4: PSK, 16cl/bit

This change should make the Manchester 32clock/bit variant and possibly also 16clock/bit PSK variant.
The code is not very nice, but I'm unfamiliar with the codebase to think of something better right now. Suggestions are welcome!

Verification

  • Get EM4100 card with 32 clock cycles / bit (or program T5577 in that way)
  • Reading it should fail before applying this PR and succeed after applying this PR.

Checklist (For Reviewer)

  • PR has description of feature/bug or link to Confluence/Jira task
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

@xMasterX
Copy link
Contributor

xMasterX commented Jan 31, 2024

Hi!

I've tested with two different T5577 tags and pm3

64 clock - works fine
32 clock - works fine
16 clock - flipper can't read them at all but can emulate properly, and write on T5577 (no success screen cuz no read but the tag is written successfuly and can be read with proxmark)
Manual read in ASK or PSK modes doesnt help, it can't see RF/16 tag at all

skotopes
skotopes previously approved these changes Feb 15, 2024
@skotopes skotopes merged commit 8780437 into flipperdevices:dev Feb 15, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants