Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix various crashes if debug libraries used #3144

Merged
merged 8 commits into from
Oct 12, 2023
Merged

Fix various crashes if debug libraries used #3144

merged 8 commits into from
Oct 12, 2023

Conversation

skotopes
Copy link
Member

@skotopes skotopes commented Oct 12, 2023 •
edited by hedger
Loading

What's new

  • Fix various crashes with LIB_DEBUG=1
  • Libs: update ERC and MGG contrast
  • Furi: fix double crash caused by bkpt use outside of debug session
  • FuriHal: enable HSI in stop mode only if we use STOP0, proper SMPS selected clock assert
  • Various PVS warning fixes
  • FuriHal: fix incorrect CCID statuses returned in some cases
  • Update display contrast

Verification

  • ./fbt LIB_DEBUG=1 flash_usb_full
  • full set of tests

Checklist (For Reviewer)

  • PR has description of feature/bug or link to Confluence/Jira task
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

@github-actions
Copy link

PVS-Studio report for commit 80d42409:

@github-actions
Copy link

github-actions bot commented Oct 12, 2023 •
edited
Loading

Compiled f7 firmware for commit 4ee99f10:

@skotopes skotopes requested a review from Skorpionm as a code owner October 12, 2023 01:36
@skotopes skotopes mentioned this pull request Oct 12, 2023
Closed
3 tasks
@hedger hedger merged commit f45a5df into dev Oct 12, 2023
@hedger hedger deleted the aku/debug_lib_crashes branch October 12, 2023 16:34
@hedger hedger added Bug Core+Services HAL, furi & core system services labels Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hedger hedger hedger approved these changes

@DrZlo13 DrZlo13 Awaiting requested review from DrZlo13 DrZlo13 is a code owner

@gornekich gornekich Awaiting requested review from gornekich gornekich is a code owner

@Astrrra Astrrra Awaiting requested review from Astrrra Astrrra is a code owner

@nminaylov nminaylov Awaiting requested review from nminaylov nminaylov is a code owner

@Skorpionm Skorpionm Awaiting requested review from Skorpionm Skorpionm is a code owner

Assignees
No one assigned
Labels
Bug Core+Services HAL, furi & core system services
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@skotopes @hedger