Skip to content

Music player rework #1189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
May 5, 2022
Merged

Music player rework #1189

merged 14 commits into from
May 5, 2022

Conversation

@skotopes
Copy link
Contributor

@skotopes skotopes commented May 2, 2022 •
edited
Loading

What's new

  • MusicPlayer: rewrite and refactor. Add ability to open RTTTL and FMF files.

Verification

  • Compile and upload
  • Upload RTTTL ringtone to music_player folder on SD
  • Try to open them with Music Player app

Checklist (For Reviewer)

  • PR has description of feature/bug or link to Confluence/Jira task
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

@skotopes skotopes requested a review from DrZlo13 as a code owner May 2, 2022 20:46
@skotopes skotopes marked this pull request as draft May 2, 2022 20:46
@github-actions
Copy link

github-actions bot commented May 2, 2022 •
edited
Loading

Click here for the DFU file to flash the 532bbd86 version of this branch with the Install from file option in qFlipper.

@skotopes skotopes mentioned this pull request May 3, 2022
Closed
3 tasks
@skotopes skotopes changed the title Music player: cli tool and new worker Music player rework May 3, 2022
@skotopes skotopes marked this pull request as ready for review May 5, 2022 00:43
@DrZlo13 DrZlo13 merged commit f5175e1 into dev May 5, 2022
@DrZlo13 DrZlo13 deleted the aku/music_player branch May 5, 2022 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DrZlo13 DrZlo13 DrZlo13 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@skotopes @DrZlo13