do not use mass assignment anymore for active record adapter #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnunemaker
approved these changes
Oct 10, 2016
| # race condition, but add is only used by enable/disable which happen | ||
| # super rarely, so it shouldn't matter in practice | ||
| @feature_class.where(attributes).first || @feature_class.create!(attributes) | ||
| unless @feature_class.find_by_key(feature.key) |
There was a problem hiding this comment.
I think dynamic finders are deprecated find_by_key which is why I went with the less aesthetically pleasing where(...).first. Would you mind swapping this back to the where so it is more future proof?
AlexWheeler
force-pushed
the
activerecord-adapter-dont-mass-assign
branch
from
8010637
to
ead8b6b
Compare
* breaks rails 3 due to mass assignment violations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #161